Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Code signing support #658 #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fran-Rg wants to merge 11 commits into terraform-aws-modules:master
base: master
Choose a base branch
Loading
from Fran-Rg:issue-658

Conversation

@Fran-Rg
Copy link
Contributor

@Fran-Rg Fran-Rg commented Jul 16, 2025

Is your request related to a new offering from AWS?

Yes ✅: please list the AWS provider version which introduced this functionality
All visible on https://github.com/terraform-aws-modules/terraform-aws-lambda/blob/master/examples/code-signing/main.tf#L55

Is your request related to a problem? Please describe.

To support code signing with this module it's required to pre-zip and upload the file to s3. This causes an issue when we rely on the packaging happening within the module as the zip is produced within the module and can't be signed.

Describe the solution you'd like.

Add a aws_signer_signing_job resource with expected variables:

[required] enable code signing
[required] signing profile_name
[optional] destination s3 prefix otherwise use the same as var.s3_prefix
[optional] destination s3 bucket otherwise use the same bucket as var.s3_bucket

Describe alternatives you've considered.

I tried to use the output module.this.s3_object.bucket to sign it and inject it to the s3_existing_package but that creates a looping dependency.

Additional context

Checkov rates code signing as a high finding: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-272

Breaking Changes

No

How Has This Been Tested?

  • [ X ] I have updated at least one of the examples/code-signing/main.tf to demonstrate and validate my change(s)

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a start, but it needs a bit more work to be merged.

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

Copy link
Contributor Author

Fran-Rg commented Sep 1, 2025

@antonbabenko ready for a re-review

Copy link
Contributor Author

Fran-Rg commented Sep 22, 2025

@antonbabenko any opinion?

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

Copy link
Contributor Author

Fran-Rg commented Oct 23, 2025

Not stale. @antonbabenko free to review and examples updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonbabenko antonbabenko antonbabenko requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /